refactor(themes): add dark variables, move base out of themes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19357308278Details
💛 - Coveralls |
rkaraivanov
approved these changes
Nov 14, 2025
|
@damyanpetev I will approve this implementation for now, however, I'd like to move to consuming the colors from the grid schemas in the theming package. We need to create an issue for that, but I don't have the rights to do it myself. |
simeonoff
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored grid themes to components in
igniteui-webcomponentswith base loaded permanently instead of bundled with each theme.Dark theme host variables copied from from
igniteui-webcomponents's third-party styles like:https://github.com/IgniteUI/igniteui-webcomponents/blob/238c17763ab4c094cb0bb4701ee9ebd147c8b386/src/styles/themes/third-party/grid/bootstrap.dark.scss#L5-L14
Since those are added on top of the single light available before, kept the rest of the variables from that in each theme - those could be refactored into a common (as noted) but even like this the themes are smaller now without base and fully self-contained.